Fix CI #404
Merged
Fix CI #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a failure when building the sphinx documentation, run_test_suite.yml should still run the Fortran tests.
Setting "continue-on-error: True" for the documentation resulted in the test passing even though "Build docs" failed -- I was hoping the test would fail, but that I would also be able to see if the "Run Test Suite" step passed or failed. I'd rather be notified of a failure of the python code and not know the status of the documentation build than the other way around.
Newer versions of MarkupSafe and jinja2 don't play nicely with the (older) version of sphinx we are using; updating py_requirements.txt won't allow these newer versions to be used.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not unusual for the continuous integration to fail several months after it was last run -- changes in the python stack often cause problems. This PR fixes some of the CI infrastructure without relying on changes to code that gets compiled / executed by MARBL itself.